[PATCH 1 of 3 v4] store: implement fncache path mangling code in C

Bryan O'Sullivan bos at serpentine.com
Fri Sep 7 15:10:10 CDT 2012

On Fri, Sep 7, 2012 at 12:45 PM, Adrian Buehlmann <adrian at cadifra.com>wrote:

> What I still don't understand is, why is it worth the risk (and
> the effort) here?

Because I don't want Mercurial to act slow for arbitrary reasons. If I
implemented only the fast encoding in C, we'd be left in a situation where
sometimes the performance would be good, sometimes bad, and this would
depend on the conventions around naming in a particular repo. This is both
hard to understand and difficult to justify to users.

I'm not thrilled to have both code paths duplicated, but I think it's worth
it to give a more uniform experience.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120907/821d02f6/attachment.html>

More information about the Mercurial-devel mailing list