[PATCH 04 of 10] wireproto: bypass filechunkiter for small files when streaming

Mads Kiilerich mads at kiilerich.com
Thu Sep 13 19:03:32 CDT 2012

Bryan O'Sullivan wrote, On 09/14/2012 01:14 AM:
> On Thu, Sep 13, 2012 at 3:06 PM, Mads Kiilerich <mads at kiilerich.com 
> <mailto:mads at kiilerich.com>> wrote:
>     Failure _is_ not an option. (The test should perhaps complain harder.)
> I don't know what you mean here. The test is wrong in this particular 
> case.

The test detected that check-code reported an error - not just a warning 
which could have been whitelisted.

That error has to be dealt with in some other way.

I guess the advice given by check-code should be followed. 
opener().read() might cause problems with Python implementations that 
doesn't use reference counting, especially on Windows.


More information about the Mercurial-devel mailing list