[PATCH 2 of 4] http: add passwordmgr.setrequest hook

Bryan O'Sullivan bos at serpentine.com
Fri Sep 14 15:54:12 CDT 2012


On Fri, Sep 14, 2012 at 7:46 AM, Markus Zapke-Gründemann <
markuszapke at gmx.net> wrote:

> +        try:
> +            self.pwmgr.setrequest(req)
> +        except AttributeError:
> +            pass
>

This is quite ugly. Please add a base setrequest method that does nothing
instead, and get rid of the try/catch clause.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120914/6dd00a3d/attachment.html>


More information about the Mercurial-devel mailing list