[PATCH 4 of 4] keyring: add new extension keyring

Mads Kiilerich mads at kiilerich.com
Fri Sep 14 18:00:17 CDT 2012

Bryan O'Sullivan wrote, On 09/14/2012 10:56 PM:
> On Fri, Sep 14, 2012 at 7:46 AM, Markus Zapke-Gründemann 
> <markuszapke at gmx.net <mailto:markuszapke at gmx.net>> wrote:
>     keyring: add new extension keyring
> I'm confused by how this relates to the previous patch. Why are there 
> two patches to do seemingly one thing?

That is probably partly my fault. I suggested posting it this way to 
make it clear what had been changed compared to the external extension.

This way of posting it now makes it clear that a lot is changed compared 
to the "known" and tested extension. Reviewing the changes this way is 
not feasible.

I suggest splitting it up in minor reviewable patches. Most of them 
should perhaps be applied upstream and have some testing there before it 
all is moved into Mercurial. Adhering to Mercurials coding standards (as 
mentioned in the comment to patch 3) could be the first patch.


More information about the Mercurial-devel mailing list