[PATCH 4 of 4] keyring: add new extension keyring

Marcin Kasperski Marcin.Kasperski at mekk.waw.pl
Sat Sep 15 05:09:49 CDT 2012

Two remarks from my side (mercurial_keyring maintainer):

a) I am open to accepting coding standard patches to mercurial_keyring.
   Preferably in some chunks so diff is readable…

b) In my personal opinion the best sequence of things is

   1. Patch Mercurial core so password management can be plugged in
   without monkeypatching (and plugin gets some necessary info - which
   password, for which user (if set), was the password wrong…)

   2. Patch mercurial_keyring (still kept separate) so it uses this

   3. Adapt mercurial_keyring to mercurial coding standards etc.

   4. Consider moving mercurial_keyring to mercurial core.

Point 1. may be of use not only for mercurial_keyring, there are many
password management schemes and tools nowadays… 

More information about the Mercurial-devel mailing list