[Bug 3629] New: lfcommands.py crashes, line 148, TypeError

[bugzilla-daemon at bz.selenic.com]

http://bz.selenic.com/show_bug.cgi?id=3629

          Priority: normal
            Bug ID: 3629
                CC: mercurial-devel at selenic.com, natosha at gmail.com
          Assignee: bugzilla at selenic.com
           Summary: lfcommands.py crashes, line 148, TypeError
          Severity: bug
    Classification: Unclassified
                OS: All
          Reporter: tismer at stackless.com
          Hardware: All
            Status: UNCONFIRMED
           Version: 2.3.1
         Component: largefiles
           Product: Mercurial

When using

hg lfconvert

hg crashes on some machines, regardless whish OS.
Happens with 2.3.1 and also 2.2.1

The behavior depends on some caching, which I did not track down.
But this is clearly wrong:

lfcommands.py, getfilectx, line 148:

        open(path, 'rb')

is not correct, because path may be None, and the open should be skipped.

As a quick workaround, I inserted in line 150:

    except TypeError:
        pass

A better fix would be to make the file operations code conditional and skip
it when path is None.

Cheers - Chris

-- 
You are receiving this mail because:
You are on the CC list for the bug.