[PATCH 2 of 4 RFC V2] formatter: add base implementation of data method

David M. Carr david at carrclan.us
Thu Sep 20 13:48:22 CDT 2012


On Thu, Sep 20, 2012 at 2:33 PM, Bryan O'Sullivan <bos at serpentine.com> wrote:
> On Sat, Sep 15, 2012 at 10:44 PM, David Carr <davidmc24 at gmail.com> wrote:
>>
>> +        for k, v in data.iteritems():
>> +            self._item[k] = v
>
>
> Both much faster and more concise as:
>
> self._item.update(data)

Sounds reasonable to me.  I'll put together a patch to make that change.
-- 
David M. Carr
david at carrclan.us


More information about the Mercurial-devel mailing list