[Bug 3639] New: Internet Explorer 9 does not show graphs from hg serve

[bugzilla-daemon at bz.selenic.com]

http://bz.selenic.com/show_bug.cgi?id=3639

          Priority: normal
            Bug ID: 3639
                CC: mercurial-devel at selenic.com
          Assignee: bugzilla at selenic.com
           Summary: Internet Explorer 9 does not show graphs from hg serve
          Severity: bug
    Classification: Unclassified
                OS: Windows
          Reporter: peterhull90 at gmail.com
          Hardware: PC
            Status: UNCONFIRMED
           Version: 2.3.1
         Component: hgweb
           Product: Mercurial

If I start a local web server with hg serve and browse to that page with
internet explorer 9 on Win7, then choose the 'graph' page, no graph is shown.

There is a script error,
SCRIPT5007: Unable to get value of the property 'initElement': object is null
or undefined 
mercurial.js, line 28 character 48

This refers to templates\static\mercurial.js
if (navigator.userAgent.indexOf('MSIE') >= 0) this.canvas =
window.G_vmlCanvasManager.initElement(this.canvas);

I think the problem is that the canvas replacement library (excanvas) doesn't
install itself for IE9 (not needed, presumably), but the check on line 28 of
mercurial.js applies to all versions of IE. On IE9 it finds that
G_vmlCanvasManager is null, hence the error.

Suggest replacement:
if (G_vmlCanvasManager) this.canvas =
window.G_vmlCanvasManager.initElement(this.canvas);

-- 
You are receiving this mail because:
You are on the CC list for the bug.