[PATCH 3 of 3 clfilter-part2] hidden: remove tags use in hidden computation

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Sep 27 18:12:13 CDT 2012


# HG changeset patch
# User Pierre-Yves David <pierre-yves.david at logilab.fr>
# Date 1346675731 -7200
# Node ID 43b35b70f0a42d34a536ba17baf9928a7c002e8b
# Parent  730611d938032350c755497ba5f478d0f1fbbdd3
hidden: remove tags use in hidden computation

Tags initially prevented revision to be hidden. It seemed a bad idea to have
tags refer to revisions that one can't see. But proper filtering of hidden
revisions excludes them from tag computation. Coming changelog filtering will do
that. Anyway, tags that really matter will likely be public and therefore not
hidden.

The current working directory parent and bookmarked revision are still not
hidden. Bookmarks were likely automatically moved at rewrite time, bookmarks
that remain on obsolete revisions were probably moved there on purpose.

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -312,7 +312,7 @@
         hidden = set()
         if self.obsstore:
             ### hide extinct changeset that are not accessible by any mean
-            hiddenquery = 'extinct() - ::(. + bookmark() + tagged())'
+            hiddenquery = 'extinct() - ::(. + bookmark())'
             hidden.update(self.revs(hiddenquery))
         return hidden
 


More information about the Mercurial-devel mailing list