[PATCH] V12 of experiment for a simpler path encoding for hashed paths (for "fncache2")

Adrian Buehlmann adrian at cadifra.com
Sat Sep 29 01:20:19 CDT 2012


On 2012-09-29 00:43, Bryan O'Sullivan wrote:
> On Fri, Sep 28, 2012 at 2:26 PM, Adrian Buehlmann <adrian at cadifra.com
> <mailto:adrian at cadifra.com>> wrote:
> 
>     V12 replaces periods and spaces with ~ *everywhere*. These are dangerous
>     characters.
> 
>     The period in "nul.txt" is thus replaced with a tilde, so you get
>     "nul~txt", which is not a reserved name anymore.
> 
> 
> Ah, I'd missed that detail. That makes sense to me.
>  
> 
>     I think we should escape com0..com9 and lpt0..lpt9 (despite what the MS
>     document says).
> 
> 
> Sounds like it.
> 
> This patch is looking good to me. I'm not currently seeing any problems
> with it. Have you tried writing a pure Python version yet?

Thanks for looking at it.

I started doing the Python version. Not yet completed. The ideas for
tweaking the C code kept popping up so far. Bit I think V12 is pretty
good so far.

I'll do a V13 which additionally escapes com0 and lpt0. And then the
Python code.




More information about the Mercurial-devel mailing list