[PATCH 1 of 1] pathencode: remove unnecessary #include directive

David Soria Parra dsp at php.net
Sat Sep 29 14:21:07 CDT 2012


On 2012-09-29, André Sintzoff <andre.sintzoff at gmail.com> wrote:
> # HG changeset patch
> # User Andr? Sintzoff <andre.sintzoff at gmail.com>
> # Date 1348943260 -7200
> # Node ID effc593454fa8be68f7225d32b84e22308d82226
> # Parent  5c89e7fa5bc20597080494aea43a09903e9e7a6a
> pathencode: remove unnecessary #include directive

Removing util.h is bad. It's the compatibility layer
for different python versions. E.g. if you don't have python 2.5
installed Py_ssize_t won't be defined which is used in patchencode.c.

I think the proper way is to check if isset is defined on a macos and
undef it.



More information about the Mercurial-devel mailing list