[PATCH 0 of 1 ] pathencode: remove unnessary #include directive

Adrian Buehlmann adrian at cadifra.com
Sat Sep 29 15:22:40 CDT 2012

On 2012-09-29 20:53, André Sintzoff wrote:
> On my "old" Mac, revision 9535a0dc41f2 does not compile.
> There is a name conflict with isset which is also a macro defined in
> /Developer/SDKs/MacOSX10.4u.sdk/usr/include/sys/param.h
> This file is included by
> . mercurial/util.h
> .. /Developer/SDKs/MacOSX10.4u.sdk/usr/include/arpa/inet.h
> ... /Developer/SDKs/MacOSX10.4u.sdk/usr/include/sys/param.h
> As there is no need to include mercurial/util.h, I remove the corresponding
> #include directive.
> Note: as I don't know if all this stuff is worth to be included in the commit
> message, I don't add it.

Thanks for reporting.

util.h is required and needs to stay. For example it has the define for
uint32_t which is needed when compiling with Microsoft C.

Perhaps the isset function defined in pythencode.c can be renamed to
something else. Maybe "inset"?

More information about the Mercurial-devel mailing list