process has an unreachable return since 523625e46760 (class engine in mercurial/

Adrian Buehlmann adrian at
Sun Sep 30 03:31:26 CDT 2012

On 2012-09-30 09:41, Simon Heimberg wrote:
> The 2nd return was introduced in 523625e46760. Not sure if this one or the
> original one should be kept.
> Code of function process from class engine: 
>   def process(self, t, mapping):
>            '''Perform expansion. t is name of map element to expand.
>            mapping contains added elements for use during expansion. Is a
>            generator.'''
>            return _flatten(func(self, mapping, data) for func, data in
>                             self._load(t))
>            return _flatten(runtemplate(self, mapping, self._load(t)))


This is an example of a bug that could have been easily catched if patch
523625e46760 would have been sent to the list for review *before* it was

More information about the Mercurial-devel mailing list