[PATCH 1 of 2] dicthelpers.diff: compare against default for missing values

Bryan O'Sullivan bos at serpentine.com
Wed Apr 10 13:29:57 CDT 2013


On Wed, Apr 10, 2013 at 11:21 AM, Siddharth Agarwal <sid0 at fb.com> wrote:

> dicthelpers.diff: compare against default for missing values
>
> This is not only a bit faster, but also aligns with caller's expectations
> better since we can legitimately have manifestdict's _flags set to ''
> instead
> of unset.
>

This is all well and good, but it's now looking like a special-purpose
function that does exactly what manifestmerge needs, rather than a function
that belongs in a notionally general purpose module?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130410/c4cbe41d/attachment.html>


More information about the Mercurial-devel mailing list