[PATCH] Bug 3749 --help does not show non-command help topics

Matt Mackall mpm at selenic.com
Tue Apr 16 08:18:07 CDT 2013


On Tue, 2013-04-16 at 15:23 +0530, Ankur Ankan wrote:
> # HG changeset patch
> # User Ankur Ankan <ankurankan at gmail.com>
> # Date 1366096607 -19800
> #      Tue Apr 16 12:46:47 2013 +0530
> # Node ID 9014d2cc9eee50f8b2369c142ba9041a86b29720
> # Parent  257afe5489d4a6ebca6a9e13bba1b69a9289b89d
> help: --help showing non-command help topics

Getting closer.

The commit message should probably be something like:

  help: show topic help with --help (issue3749)

  This should make 'hg --help revsets' work, with enabling 'hg revsets
  --help'.

Also: this probably needs two short tests added to tests/test-help.t to
match the above.

> I know this patch doesn't look good. A better solution that I thought
> was to pass an optional parameter (say ishelp) to findcmd which would
> be True if --help flag is set. And if ishelp is True findcmd would
> return the cmd in aliases without checking if it is in the table. The
> problem here is what should be the value of "entry"?

I think your first patch was closer?

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list