[PATCH] zsh_completion: hide commands' stderr when parsing their output

Brendan Cully brendan at kublai.com
Wed Apr 17 11:42:29 CDT 2013


On Wednesday, 17 April 2013 at 20:40, Nikolaj Sjujskij wrote:
> Den 2013-04-17 20:36:55 skrev Brendan Cully <brendan at kublai.com>:
> 
> >On Wednesday, 17 April 2013 at 11:49, Nikolaj Sjujskij wrote:
> >>Brendan, while we're at it. Another questionable change made in zsh.git:
> >>
> >>diff --git a/contrib/zsh_completion b/contrib/zsh_completion
> >>--- a/contrib/zsh_completion
> >>+++ b/contrib/zsh_completion
> >>@@ -564,8 +564,8 @@
> >> _hg_cmd_commit() {
> >>   _arguments -s -w : $_hg_global_opts $_hg_pat_opts $_hg_subrepos_opts
> >>\
> >>   '(--addremove -A)'{-A,--addremove}'[mark new/missing files as
> >>added/removed before committing]' \
> >>-  '(--message -m)'{-m+,--message}'[use <text> as commit message]:text:'
> >>\
> >>-  '(--logfile -l)'{-l+,--logfile}'[read commit message from <file>]:log
> >>file:_files -g \*.txt' \
> >>+  '(--message -m)'{-m+,--message}'[specify commit message]:text' \
> >>+  '(--logfile -l)'{-l+,--logfile}'[read commit message from specified
> >>file]:log file:_files' \
> >>   '(--date -d)'{-d+,--date}'[record datecode as commit date]:date
> >>code:' \
> >>   '(--user -u)'{-u+,--user}'[record user as commiter]:user:' \
> >>   '--amend[amend the parent of the working dir]' \
> >>
> >>Apart from difference in descriptions (which I intend to keep closer to
> >>help
> >>entries), there's two things:
> >> * should we really complete --logfile with .txt-files only? Doesn't
> >>sound like a big deal, but...
> >
> >I'm -1 on this.
>  -1 on completing only *.txt files (current situation) or changing it to
> complete all files?

Ah, I'd misread this. I think it assumes too much to only complete
.txt files here. I prefer completing anything.


More information about the Mercurial-devel mailing list