[PATCH] annotate: discard refcount of discarded annotation for memory efficiency

FUJIWARA Katsunori foozy at lares.dti.ne.jp
Thu Apr 18 05:53:25 CDT 2013


# HG changeset patch
# User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
# Date 1366282204 -32400
# Node ID 62a35a09bae098a022f865d54cfdb04be168626c
# Parent  7d31f2e42a8afb54c8fae87e8e3e29a63578aea4
annotate: discard refcount of discarded annotation for memory efficiency

Before this patch, refcount (managed in "needed") of the annotation
result is kept as 1, even if corresponding annotation result is
discarded from "hist", because it isn't decreased and discarded.

In the history tree including merging revision, the most recent common
ancestor of merged revisions is scanned twice. Refcount of such
ancestor never becomes 0, because refcount is started from 1 at the
second scanning.

This prevents annotation results of merging revision in "hist" from
being discarded, and decreases memory efficiency.

This patch discards refcount of the annotation result, when the
corresponding annotation is discarded from "hist".

diff --git a/mercurial/context.py b/mercurial/context.py
--- a/mercurial/context.py
+++ b/mercurial/context.py
@@ -713,6 +713,7 @@
                         curr = pair(hist[p], curr)
                     if needed[p] == 1:
                         del hist[p]
+                        del needed[p]
                     else:
                         needed[p] -= 1
 


More information about the Mercurial-devel mailing list