[PATCH] use correct locking in histedit and cause 'invalid branchheads cache' warning

[Mads Kiilerich]

On 04/18/2013 05:41 AM, Matt Mackall wrote:
> On Wed, 2013-04-17 at 22:15 -0500, Kevin Bullock wrote:
>> On 17 Apr 2013, at 6:50 PM, Mads Kiilerich wrote:
>>
>>> # HG changeset patch
>>> # User Mads Kiilerich <madski at unity3d.com>
>>> # Date 1366162894 -7200
>>> # Node ID 3f941a21632b4ff545eadb43418744f2edcf0e4a
>>> # Parent  341083b02d1be3fc707f27c360981bb00213dd07
>>> use correct locking in histedit and cause 'invalid branchheads cache' warning
>>>
>>> I don't know why it introduces a warning - it shouldn't.
>>>
>>> 'tip differs' is a very brief and (like other branchmap messages messages)
>>> untranslated user-facing message. It comes from branchmap.read where all kinds
>>> of exceptions are caught and mangled into warnings.
>> It's a result of the branchcache collaboration changes from just before 2.5 and only shows up with --debug.
> I can't tell if this patch is an RFC or what.

It is a bad patch - primarily because it shows how adding innocent and 
correct locking has a strange side effect.

So I guess it was more of a bug report or 'request for research and fix' 
than a RFC.

/Mads