[Bug 3894] New: base85.py implementation susceptible to Python issue14596

mercurial-bugs at selenic.com mercurial-bugs at selenic.com
Thu Apr 18 17:18:59 CDT 2013


http://bz.selenic.com/show_bug.cgi?id=3894

          Priority: normal
            Bug ID: 3894
                CC: mercurial-devel at selenic.com
          Assignee: bugzilla at selenic.com
           Summary: base85.py implementation susceptible to Python
                    issue14596
          Severity: bug
    Classification: Unclassified
                OS: All
          Reporter: mm-hgbz at ensoft.co.uk
          Hardware: All
            Status: UNCONFIRMED
           Version: unspecified
         Component: Mercurial
           Product: Mercurial

Python issue14596 describes a "feature" of the struct module that makes it hold
on to (and appear to leak) large amounts of memory for large, dynamically sized
structs created with the struct.pack and struct.unpack shortcuts.

The Mercurial base85.py implementation makes use of these, and so could use
lots of memory if run repeated. The workaround is to explicitly create a
struct.Struct(), which will then be freed when it goes out of scope.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Mercurial-devel mailing list