[PATCH] hgweb: remove stripes from code views

[Mads Kiilerich]

On 04/21/2013 02:26 AM, Pierre-Yves David wrote:
> On 20 avr. 2013, at 16:37, Александр Плавин wrote:
>
>> Could you please accept/queue this to the mentioned gsoc queue? It seems that nobody is against this patch.
> I'm thinking about this for a few days and I'm "happy" to tell you that I'm officially against this patch!

That's a very strong statement.

> I like those stripes. They help me to read and to relate a line number with line
> (look at this file for example http://selenic.com/hg/file/93493746c89a/mercurial/localrepo.py#l1804)
>
> I do not buy the line numbers or rendering argument. Can Jordi elaborate on this?
>
> However we could probably the way we do this stripes and line numbering. Modern CSS can help there if we are ok with lower support of older browser.
>
> I've made some quick experiment here: http://www.octopoid.net/perso/tmp/nu.html#l.1

Reading your supporting arguments it seems to me like you actually agree 
that we could do better than these parity stripes. So I guess the 
rejection came out stronger than it perhaps had to be.

I agree that removing the stripes without anything to replace it in some 
ways will give a worse UI (but also in some ways a better UI).

My personal opinion: I would prefer a simple
   .source:hover{background-color:#eee;}
or something along the lines of
   .source:hover{border-top: 1px solid #eee;margin-top:-1px;}
that highlights the hovered line instead of the parity stripes.

For links to specific lines it would be even more convenient to have 
something like
   .source :target{background-color:yellow;}
that in most browsers highlights the linked target (which should be the 
whole line).

/Mads