[PATCH] hgweb: make help verbose again (issue3899)

Kevin Bullock kbullock+mercurial at ringworld.org
Mon Apr 22 13:19:49 CDT 2013


On Apr 22, 2013, at 12:45 PM, Matt Mackall wrote:

> On Mon, 2013-04-22 at 12:27 -0500, Kevin Bullock wrote:
>> On Apr 22, 2013, at 12:06 PM, Александр Плавин wrote:
>> 
>>> 2013/4/22 Kevin Bullock <kbullock+mercurial at ringworld.org>
>>> On Apr 22, 2013, at 3:53 AM, Alexander Plavin wrote:
>>> 
>>>> # HG changeset patch
>>>> # User Alexander Plavin <me at aplavin.ru>
>>>> # Date 1366619276 -14400
>>>> #      Mon Apr 22 12:27:56 2013 +0400
>>>> # Branch stable
>>>> # Node ID 535ef0450d4d28784def15c4aca53f64260cc6a4
>>>> # Parent  292cd385856d98bacb2c3086f8897bc660c2beea
>>>> hgweb: make help verbose again (issue3899)
>>>> 
>>>> Due to regression introduced in f5db3092790f, help in hgweb
>>>> was rendered in non-verbose form (issue3899)
>>> 
>>> If this was a regression, how did an existing test case detect the fix but not the regression?
>>> 
>>> This test was modified in that revision too, so it accepted incorrect behavior.
>> 
>> Okay, makes sense. But so here's a weird thing:
>> 
>> --- /home/kbullock/hg/hg/tests/test-help.t
>> +++ /home/kbullock/hg/hg/tests/test-help.t.err
>> @@ -1628,6 +1628,26 @@
>>   </body>
>>   </html>
>> 
>> +  $ ls
>> +  addverboseitems.py
>> +  addverboseitems.pyc
> 
> The test harness is interpreting the example.

Noticed that, got a fixed version of the patch queued.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list