[PATCH 2 of 2 STABLE MOST-WANTED] push: make locking of source optional (issue3684)

Matt Mackall mpm at selenic.com
Tue Apr 30 10:38:35 CDT 2013


On Tue, 2013-04-30 at 12:04 +0200, pierre-yves.david at logilab.fr wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at logilab.fr>
> # Date 1367315511 -7200
> #      Tue Apr 30 11:51:51 2013 +0200
> # Branch stable
> # Node ID 4be1d06df73f0092277b83e243ba4ca583c040e0
> # Parent  b5c9626ec444375a6368d40ba5218ede6401c68d
> push: make locking of source optional (issue3684)
> 
> Having the permission to lock the source repo on push is now optional. When the
> repo cannot be locked, phase are not changed locally. A status message is issue
> when some actual phase movement are skipped:
> 
>     public phase unchanged locally, cannot lock repo

This message will confuse people because it puts cause after effect and
uses the passive voice for the effect. It might be read as:

 "some mysterious phase thing is wrong, therefore cannot lock repo"

How about:

 cannot lock source repo, not marking source changesets public

Or:

 cannot lock source repo, not updating source phases


-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list