[PATCH 1 of 2] dispatch: move command line --config argument parsing to _runcatch()

Sean Farley sean.michael.farley at gmail.com
Wed Aug 7 15:47:12 CDT 2013


kbullock+mercurial at ringworld.org writes:

> On 13 Jul 2013, at 5:16 PM, Sean Farley wrote:
>
>> # HG changeset patch
>> # User Sean Farley <sean.michael.farley at gmail.com>
>> # Date 1373751187 18000
>> #      Sat Jul 13 16:33:07 2013 -0500
>> # Node ID 15a903bca551318cd0c3f42484374a8b8acd08e5
>> # Parent  3af3a165db18ed093394fe661e797bea296dc602
>> dispatch: move command line --config argument parsing to _runcatch()
>> 
>> Previously, command line parsing of --config arguments was done in
>> _dispatch. This means that it takes place after activating the debugger. In an
>> upcoming patch, we will add a ui.debugger setting so we need to have this
>> parsing done before _runcatch.
>
> One (probably) small issue: now we can't run the debugger (conveniently) on _parseconfig of options set on the command line.

I've adjusted this in the second version to trigger the debugger
correctly for an error in _parseconfig. Alternatively, we could call
_parseconfig twice?


More information about the Mercurial-devel mailing list