[PATCH 4 of 4] hgweb: remove now unnecessary explicit header() and footer()

Martin Geisler martin at geisler.net
Fri Aug 9 02:07:52 CDT 2013


Alexander Plavin <alexander at plav.in> writes:

> # HG changeset patch
> # User Alexander Plavin <alexander at plav.in>
> # Date 1374621626 -14400
> #      Wed Jul 24 03:20:26 2013 +0400
> # Node ID 11ac049356d4894642313803d9edc1ff2e9d2788
> # Parent  1fe956e499f2996d4b63ae04c2ec99fe39e89302
> hgweb: remove now unnecessary explicit header() and footer()

I think it could be nice if you added a tiny bit of context: when and
why did this become unnecessary (which changeset does "now" refer to)?

My first guess would be that the immediate parent (patch 3) makes the
functions unnecessary, but it doesn't look like it to me. So my second
guess is that "now" refers to patch 2. That suggests that the patches
could be reordered by swapping 3 and 4.

-- 
Martin Geisler


More information about the Mercurial-devel mailing list