[PATCH 4 of 4 V2] hgweb: config option to blacklist some revset functions in hgweb search

Augie Fackler raf at durin42.com
Mon Aug 12 13:22:12 CDT 2013


On Mon, Aug 12, 2013 at 2:21 PM, Alexander Plavin <alexander at plav.in> wrote:
>> Probably want to blacklist anything that does regexp matches too,
>> since we're not on re2.
>
> As I understand, blacklisting grep function and also 're:' prefix for others? I can see two ways to do this: pass an argument somehow to revset._stringmatcher function to switch off 're:' prefix check, or just replacing '\(\s+re:' with '(literal:re:' in the query string. The first methods seems more robust of course. Am I correct here?

sounds right to me. I can't think of other things that take regexps at
the moment.

>
> Btw, nice library re2, didn't see it before :)


More information about the Mercurial-devel mailing list