[PATCH 12 of 20] hgweb, paper: add shortlogajax template and use it

Matt Mackall mpm at selenic.com
Thu Aug 15 01:28:33 CDT 2013


On Thu, 2013-08-15 at 00:48 +0400, Alexander Plavin wrote:
> 
> 15.08.2013, 00:32, "Matt Mackall" <mpm at selenic.com>:
> > On Tue, 2013-08-13 at 23:24 -0500, Kevin Bullock wrote:
> >
> >>  On 13 Aug 2013, at 3:44 AM, Alexander Plavin wrote:
> >>>  13.08.2013, 12:30, "Martin Geisler" <martin at geisler.net>:
> >>>>  Another thought that occured to me when I read the discussion about
> >>>>  writing an XML style: have you considered writing a JSON style instead?
> >>>>  That might be even more useful for JavaScript code.
> >>>  In this application (I mean infinite scrolling) json style doesn't give any differences/benefits to xml one, as we would have to render the templates in JS anyway. The only difference for future uses in javascript is using xfr.responsexml vs json.parse(xfr.responsetext). So, this variants are about equivalent and one of them just has to be chosen.
> >>>  However, I don't know what will be best here, and would like to hear more opinions on this.
> >>  I'd lean towards JSON as well. There are solid, widely-available
> >>  parsers for both, but JSON is generally more compact, and more widely
> >>  used by newer client-side libraries.
> >
> > Note that both JSON and XML have a serious problem that will need to be
> > addressed before we can use them: can't pass arbitrary character sets.
> 
> What exactly can't we pass there? According to the json rfc, "All
> Unicode characters may be placed within the quotation marks except for
> the characters that must be escaped: quotation mark, reverse solidus,
> and the control characters (U+0000 through +001F).". I found it at
> http://www.ietf.org/rfc/rfc4627.txt (2.5).

Eight bit bytes in undeclared encoding. In Mercurial, that's filenames
and file contents. See:

http://mercurial.selenic.com/wiki/GenericTemplatingPlan?highlight=%
28utf-8b%29#JSON.2C_XML.2C_and_encoding_troubles

Also, neither JSON nor XML can handle strings with NUL bytes at all.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list