[PATCH 2 of 3 V3] schemas: add schemas listkeys implementation

Martin Geisler martin at geisler.net
Thu Aug 15 03:04:12 CDT 2013

Durham Goode <durham at fb.com> writes:

> # HG changeset patch
> # User Durham Goode <durham at fb.com>
> # Date 1375827497 25200
> #      Tue Aug 06 15:18:17 2013 -0700
> # Node ID d43e79e852d560c9990aa2ac2de878c73e9b88ad
> # Parent  84ac4b920802805474d203b5b5dc1cd4aa861256
> schemas: add schemas listkeys implementation
> This adds the wire protocol logic for requesting and transmitting
> schema data. It is transmitted via the existing listkeys protocol,
> but schemas cannot be pushed to the server.

Oh, it seems you do use the listkey system :) Great!

What confused me was that you talk about adding logic to the wire
protocol when you're really just using the existing protocol without
extending it.

In other words: this reviewer has a very short attention span and poor
read-ahead capabilities :) So think about spelling out the obvious and
highlight when you're using existing infrastructure (that automatically
makes your patch seem more elegant).

Martin Geisler

More information about the Mercurial-devel mailing list