[PATCH 1 of 4 V2] hgweb: eliminate extra complexity in process_dates definition
Alexander Plavin
alexander at plav.in
Sat Aug 17 17:35:17 CDT 2013
# HG changeset patch
# User Alexander Plavin <alexander at plav.in>
# Date 1374677635 -14400
# Wed Jul 24 18:53:55 2013 +0400
# Node ID 6106b5b83c38ce74e67dae5a11e111b46a5b4842
# Parent eca806a6c95e11fb1d0706b9903a86f448b170b4
hgweb: eliminate extra complexity in process_dates definition
There was an extra anonymous outer function, called immediately. It is removed
in this patch.
diff -r eca806a6c95e -r 6106b5b83c38 mercurial/templates/static/mercurial.js
--- a/mercurial/templates/static/mercurial.js Fri Aug 09 22:05:27 2013 +0400
+++ b/mercurial/templates/static/mercurial.js Wed Jul 24 18:53:55 2013 +0400
@@ -168,7 +168,7 @@
}
-process_dates = (function(document, RegExp, Math, isNaN, Date, _false, _true){
+function process_dates(){
// derived from code from mercurial/templatefilter.py
@@ -219,9 +219,9 @@
var delta = Math.floor((now.getTime() - once.getTime()) / 1000);
- var future = _false;
+ var future = false;
if (delta < 0){
- future = _true;
+ future = true;
delta = -delta;
if (delta > (30 * scales.year)){
return "in the distant future";
@@ -245,26 +245,24 @@
}
}
- return function(){
- var nodes = document.getElementsByTagName('*');
- var ageclass = new RegExp('\\bage\\b');
- var dateclass = new RegExp('\\bdate\\b');
- for (var i=0; i<nodes.length; ++i){
- var node = nodes[i];
- var classes = node.className;
- if (ageclass.test(classes)){
- var agevalue = age(node.textContent);
- if (dateclass.test(classes)){
- // We want both: date + (age)
- node.textContent += ' ('+agevalue+')';
- } else {
- node.title = node.textContent;
- node.textContent = agevalue;
- }
- }
- }
- }
-})(document, RegExp, Math, isNaN, Date, false, true)
+ var nodes = document.getElementsByTagName('*');
+ var ageclass = new RegExp('\\bage\\b');
+ var dateclass = new RegExp('\\bdate\\b');
+ for (var i=0; i<nodes.length; ++i){
+ var node = nodes[i];
+ var classes = node.className;
+ if (ageclass.test(classes)){
+ var agevalue = age(node.textContent);
+ if (dateclass.test(classes)){
+ // We want both: date + (age)
+ node.textContent += ' ('+agevalue+')';
+ } else {
+ node.title = node.textContent;
+ node.textContent = agevalue;
+ }
+ }
+ }
+}
function toggleDiffstat() {
var curdetails = document.getElementById('diffstatdetails').style.display;
More information about the Mercurial-devel
mailing list