[PATCH 3 of 5] histedit: discard meaningless comment about 'hexlify node'

Augie Fackler raf at durin42.com
Mon Aug 26 08:51:07 CDT 2013


On Mon, Aug 26, 2013 at 04:41:50PM +0900, FUJIWARA Katsunori wrote:
> # HG changeset patch
> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> # Date 1377501081 -32400
> #      Mon Aug 26 16:11:21 2013 +0900
> # Node ID c0dc67257c631ea0b709b189271bfd022917c022
> # Parent  33eeda9255b9fbca85819ee5d7340650b0482f17
> histedit: discard meaningless comment about 'hexlify node'

Queued the first three of this series, thanks.

>
> Refactoring in 26b41a902195 made this comment meaningless. The node
> gotten by "discovery.findcommonoutgoing()" is hexlified in "between()"
> by "repo.set('%n::%n', old, new)".
>
> diff --git a/hgext/histedit.py b/hgext/histedit.py
> --- a/hgext/histedit.py
> +++ b/hgext/histedit.py
> @@ -419,10 +419,6 @@
>      if revs:
>          revs = [repo.lookup(rev) for rev in revs]
>
> -    # hexlify nodes from outgoing, because we're going to parse
> -    # parent[0] using revsingle below, and if the binary hash
> -    # contains special revset characters like ":" the revset
> -    # parser can choke.
>      outgoing = discovery.findcommonoutgoing(repo, other, revs, force=force)
>      if not outgoing.missing:
>          raise util.Abort(_('no outgoing ancestors'))
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list