[PATCH 1 of 2] bundlerevlog: extract 'baserevision' method

Augie Fackler raf at durin42.com
Tue Aug 27 12:25:31 CDT 2013


On Tue, Aug 27, 2013 at 1:20 PM, Wojciech Lopata <lopek at fb.com> wrote:
>> Is this change (and the other ones like it) actually necessary? Is
>> filelog.filelog.revision not currently the same as revlog.revlog.revision?
>>
>> (That is: couldn't this use the method from the base class for now?)
>
> First of all, I need this change only in bundlemanifest (in bundlefilelog and bundlechangelog I added it only for consistency)


What I meant was, "do you actually need to do this explicit forwarding
of the method to the superclass, since that's what would happen if you
didn't add this particular line?" - I understand adding the hook for a
tinymanifest extension :)


More information about the Mercurial-devel mailing list