[PATCH 1 of 4 V3] hgweb: add dynamic search function selection, depending on the query

Laurens Holst laurens.nospam at grauw.nl
Wed Aug 28 08:20:07 CDT 2013


Op 27-08-13 22:15, Augie Fackler schreef:
> On Tue, Aug 27, 2013 at 3:27 AM, Alexander Plavin <alexander at plav.in> wrote:
>>> This magic string gets repeated often, over several changesets. Could
>>> I persuade you to give it a descriptive symbolic name so it's more
>>> obvious what it is to future readers?
>> Done. (assuming you mean 'kw', replaced with 'keyword')
>
> I meant something like
>
> _KEYWORD_SEARCH = 'kw'
>
> and then using the symbolic constant throughout.

Doesn’t a readable non abbreviated string serve pretty much the same 
purpose?

~Laurens


More information about the Mercurial-devel mailing list