[PATCH] Keep authentication information after the first fail HTTP access (issue3567)
Nikolaj Sjujskij
sterkrig at myopera.com
Fri Dec 20 08:46:47 CST 2013
On Fri, 20 Dec 2013 18:30:55 +0400, Stéphane Klein <sklein at bearstech.com>
wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Le 20/12/13 15:20, Nikolaj Sjujskij a écrit :
>> On Fri, 20 Dec 2013 18:01:14 +0400, Stéphane Klein
>> <sklein at bearstech.com>
>> wrote:
>>
>> Le 14/12/13 18:49, Augie Fackler a écrit :
>>>>> Aaaand I just backed it out, thanks to terrible breakage on Python
>>>>> 2.4.
>>>>>
>>>>> Sigh. Patch works great on 2.6 and 2.7, disaster on 2.4.
>>
>> This is a new version with python 2.4 bugfix.
>>
>> # HG changeset patch # User Stéphane Klein
>> <contact at stephane-klein.info> #
>> Date 1387547765 -3600 # Fri Dec 20 14:56:05 2013 +0100 # Node ID
>> ec0ec32a305f6626ccd9b79e4874ffbcd2e5ecd8 # Parent
>> 04036798ebed0c6d7062517bb49b308a15e4345e http: reuse authentication info
>> after the first failed request (issue3567)
>>> I'm sure there were a lot more lines of description here in the first
>>> version. And I believe those were useful lines nobody objected to.
>>
>
> I need to resend the full commit message in my patch ?
Well, that commit message was a part of patch you've been working on. I
wasn't sure why you have stripped it, surely you don't expect "applyer" to
cut'n'paste description from earlier version to craft a changeset himself.
Basically you were expected to resend the same patch with issues fixed
(Python 2.4 support, the first line/summary). And nobody suggested
stripping that description (because it's a good and robust one). So I
pointed out its absence in case I've missed something :)
Thanks for contributing!
--
Yrs sincerely,
Nikolaj Sjujskij
More information about the Mercurial-devel
mailing list