[Bug 4136] New: "coal" hgweb style adds extra blank line in file view

[mercurial-bugs at selenic.com]

http://bz.selenic.com/show_bug.cgi?id=4136

          Priority: normal
            Bug ID: 4136
                CC: mercurial-devel at selenic.com
          Assignee: bugzilla at selenic.com
           Summary: "coal" hgweb style adds extra blank line in file view
          Severity: bug
    Classification: Unclassified
                OS: Windows
          Reporter: chris at chrullrich.net
          Hardware: PC
            Status: UNCONFIRMED
           Version: 2.8.1
         Component: hgweb
           Product: Mercurial

In the "coal" hgweb style, there is an extra blank line after every source line
in file view.

In coal style, the fileline fragment is essentially this:

  fileline = '
    <div>{line|escape}</div>'

A newline, followed by the full source line.

In paper, on the other hand, it is:

  fileline = '
    <span>{strip(line|escape, '\r\n')}</span>'

The problem is the use of <div> in coal style, because the div pushes the
following newline (the one preceding the next div) down, resulting in a blank
line. What I do not understand is why the newline coming from the unstripped
source line does not cause another blank line.

(What I also do not understand is how a bug that was first released with
Mercurial 1.3 has not been reported before; this was introduced in
835b1ee111f4.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.