[PATCH] filter: add a comment so that people do not forget to update subsettable

pierre-yves.david at ens-lyon.org pierre-yves.david at ens-lyon.org
Mon Dec 23 15:14:28 CST 2013


# HG changeset patch
# User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
# Date 1387830231 28800
#      Mon Dec 23 12:23:51 2013 -0800
# Node ID 9510f6f79b3944f7997b0252b85c0eb572f81c43
# Parent  4274eda143cb1025be1130ffdaaf62370a2a6961
filter: add a comment so that people do not forget to update subsettable


Changeset 175c6fd8cacc moved `subsettable` from `mercurial/repoview.py` to
`mercurial/branchmap.py`. This mean that `filtertable` and `subsettable` are no
longer next to each other. So we add a comment to remind people to update both.

diff --git a/mercurial/repoview.py b/mercurial/repoview.py
--- a/mercurial/repoview.py
+++ b/mercurial/repoview.py
@@ -92,10 +92,15 @@ def computeimpactable(repo):
     # protect from nullrev root
     firstmutable = max(0, firstmutable)
     return frozenset(xrange(firstmutable, len(cl)))
 
 # function to compute filtered set
+#
+# When addding a new filter you MUST update the table at:
+#     mercurial.branchmap.subsettable
+# Otherwise you don't your filter will have to recompute all its branches cache
+# from scratch (very slow).
 filtertable = {'visible': computehidden,
                'served': computeunserved,
                'immutable':  computemutable,
                'base':  computeimpactable}
 


More information about the Mercurial-devel mailing list