[Bug 4138] New: Stack overflow in largefiles extension when enabled on wsgi http server

[mercurial-bugs at selenic.com]

http://bz.selenic.com/show_bug.cgi?id=4138

          Priority: normal
            Bug ID: 4138
                CC: mercurial-devel at selenic.com, natosha at gmail.com
          Assignee: bugzilla at selenic.com
           Summary: Stack overflow in largefiles extension when enabled on
                    wsgi http server
          Severity: bug
    Classification: Unclassified
                OS: Linux
          Reporter: bruce.cran at gmail.com
          Hardware: PC
            Status: UNCONFIRMED
           Version: 2.7.2
         Component: largefiles
           Product: Mercurial

Following the suggestion in http://bz.selenic.com/show_bug.cgi?id=4118 to
enable largefiles on my hgweb server (running 2.7.2), I'm now seeing stack
overflows:

mod_wsgi (pid=4917): Exception occurred processing WSGI script 'hgweb.wsgi'.
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mercurial/hgweb/hgwebdir_mod.py", line
153, in __call__
    return self.run_wsgi(req)
  File "/usr/lib/python2.7/dist-packages/mercurial/hgweb/hgwebdir_mod.py", line
218, in run_wsgi
    return hgweb(repo).run_wsgi(req)
  File "/usr/lib/python2.7/dist-packages/mercurial/hgweb/hgweb_mod.py", line
170, in run_wsgi
    return protocol.call(self.repo, req, cmd)
  File "/usr/lib/python2.7/dist-packages/mercurial/hgweb/protocol.py", line 76,
in call
    rsp = wireproto.dispatch(repo, p, cmd)
  File "/usr/lib/python2.7/dist-packages/mercurial/wireproto.py", line 353, in
dispatch
    return func(repo, proto, *args)
  File "/usr/lib/python2.7/dist-packages/hgext/largefiles/proto.py", line 155,
in capabilities
    return capabilitiesorig(repo, proto) + ' largefiles=serve'
File "/usr/lib/python2.7/dist-packages/hgext/largefiles/proto.py", line 155, in
capabilities
  return capabilitiesorig(repo, proto) + ' largefiles=serve'
File "/usr/lib/python2.7/dist-packages/hgext/largefiles/proto.py", line 155, in
capabilities
  return capabilitiesorig(repo, proto) + ' largefiles=serve'

I think I reverted the patch from bug 4188 correctly: as the stack trace shows,
the capabilities function now just returns capabilitiesorig(repo,proto) + '
largefiles=serve'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.