Re: [patch enhancement 4] bash_completion Use bash features, prefer (( arithmetic expressions )), [[ conditional expressions ]], avoid useless filename globbing trials in [ … ]expressionss

[Pierre-Yves David]

On 12/30/2013 12:28 PM, Roland Eggner wrote:
> On 2013-12-30 Monday at 13:39 -0600 Sean Farley wrote:
>> Thanks for the contribution! Overall, these seem fine but I admittedly
>> didn't do a thorough reading because these patches were
>> attachments. Please do take a moment to read
>>
>> http://mercurial.selenic.com/wiki/ContributingChanges
> Already done, thanks for the hint.
> AFAICS I have followed every point.

You failed at least for those two ;-)

1. first line of commit message is of the form "*topic: uncapitalized, 
no trailing period*"

4. patch is in the body of the email in the form produced by export 
<http://www.selenic.com/hg/help/export> for easy review

(no garantee that there is no other issue)


Welcome aboard!

-- 
Pierre-Yves David


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20131230/1c8859bc/attachment.html>