[patch bugfix] Skip repositories not readable with current privileges; skip empty “.hg” directories, e.g. unmounted mountpoints

[Matt Mackall]

[resent, as my MUA swallowed this yesterday morning]

On Mon, 2013-12-30 at 19:52 +0100, Roland Eggner wrote:

[attached patch]

Greetings, Roland, and thanks for your patches.

I'm afraid this patch fails items 1, 3, 4, 6, 9, 10, and probably more
of 

http://mercurial.selenic.com/wiki/ContributingChanges#Submission_checklist

Quoting that page:

        <!> If you send a patch with an underscore in a variable name,
        we'll know you haven't read this page! 

Additionally, your patch undoes the use of vfs.* methods in favor of the
os.* methods we're steadily trying to eliminate.

Lastly, some of the ideas in this patch are very likely not going to be
accepted, so submitting them all as one patch drowns the whole thing
like a boat anchor (see bullet point 6). For starters:

- empty .hg directories are perfectly valid repositories
- getting log results for /home/bob in /home/bob/project is awful,
permission errors are preferable


Rather than try to fix everything all at once, I recommend you resend
one of the simpler patches (perhaps the bash completion one) after
double-checking the checklist so we can make forward progress on your
contributions.


-- 
Mathematics is the supreme nostalgia of our time.

-- 
Mathematics is the supreme nostalgia of our time.