[PATCH STABLE] hgweb: remove baseline info from paper template

Pierre-Yves David pierre-yves.david at logilab.fr
Fri Feb 1 04:11:49 CST 2013


On Fri, Feb 01, 2013 at 10:38:21AM +0100, Mads Kiilerich wrote:
> On 02/01/2013 05:43 AM, Pierre-Yves David wrote:
> ># HG changeset patch
> ># User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> ># Date 1359693606 -3600
> ># Branch stable
> ># Node ID 80f3dd3aa40280e97289153455b493c727ef0a52
> ># Parent  2a1fac3650a5b4d650198604c82ab59969500374
> >hgweb: remove baseline info from paper template
> >
> >The user interface is not considered ready for prime time yet. The internal code stay in
> >place custom template usage. The feature is ultimatly wished and will be
> >reenabled soon. The current issue is only related to the visual of the current
> >interface.
> 
> A reference to the revision that introduced the feature, please.

good point, that's d605a82cf189

> The template keyword 'currentbaseline' is also very strange - there
> is no 'baseline' concept anywhere in Mercurial. In 'changeset' it
> should be something like 'diffparent'. Diff between arbitrary
> revisions belongs elsewhere - and then it would be more descriptive
> to call the two nodes 'anode' and 'bnode'.

Yes baseline sound wrong and is not used anywhere in Mercurial. not even
in d605a82cf189 description.

> So I suggest removing the keyword too so we can change it without
> breaking backward compatibility. Actually I suggest backing out the
> full feature until it is ready.

Bah, not sure about that. The code works so we can keep it arround but
not advertise the keywork name for now


-- 
Pierre-Yves David

http://www.logilab.fr/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130201/03ab6f0c/attachment.pgp>


More information about the Mercurial-devel mailing list