[PATCH stable] rebase: derive node from target rev (issue3802)

Siddharth Agarwal sid0 at fb.com
Sun Feb 3 17:47:29 CST 2013


On 02/03/2013 03:40 PM, Pierre-Yves David wrote:
> Can't that be just `dest = repo[target]` that would remove needs to update
> other code part. making the change smaller and safer.

That was the other way to fix this I had in mind. I mildly prefer this 
because that would have one path derive target from dest and one derive 
dest from target, and I thought that was even more confusing than this.

> I just had a look at the "function" you are patching and it size and complexity
> are really scary.

Absolutely.


More information about the Mercurial-devel mailing list