[PATCH 4 of 5 V2] manifestmerge: handle abort on local unknown, remote created files

Siddharth Agarwal sid0 at fb.com
Sat Feb 9 07:23:35 CST 2013


On 02/09/2013 12:00 PM, Mads Kiilerich wrote:
> Is this handling a new case and fixing a bug? Or is it duplicating 
> existing functionality as an optimization or cleanup?

Duplicating existing functionality in a faster manner, and the next 
patch removes the original check.

> (Should be explained here ... and perhaps tested if it makes any 
> visible changes.)

No, it doesn't make any visible changes. The next changeset doesn't, either.

> Do we have test coverage for all these cases?

Yes, spread across a bunch of tests.


More information about the Mercurial-devel mailing list