[PATCH 2 of 3] dirstate: walk returns None for files under symlink directory

Bryan O'Sullivan bos at serpentine.com
Sat Feb 9 11:32:35 CST 2013


On Tue, Feb 5, 2013 at 3:38 PM, Durham Goode <durham at fb.com> wrote:

> dirstate: walk returns None for files under symlink directory
>
> Previously dirstate.walk would return a stat object for files in the dmap
> that were under a symlink directory.  Now it will return None (when the
> unknown
> parameter is True) to indicate that they are no longer considered part of
> the
> repository.
>

This patch looks good, but "symlink directory" is awkward and confusing.

I'd use something like "symlink that replaces a directory" instead - it's
not great wording, but it doesn't make me go "what does that mean?".
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130209/5ce09ac3/attachment.html>


More information about the Mercurial-devel mailing list