[PATCH 1 of 6] blackbox: adds a blackbox extension

Durham Goode durham at fb.com
Sun Feb 10 09:31:46 CST 2013

Thanks for the comments.

>Also, what about calling this "track" instead of "trackedevents"?

I went through the existing config options and 'track' does seem to be
more consistent. Will do.

>There should be spaces between = here. Running check-code should catch

Check-code didn't catch this.

>> +def reposetup(ui, repo):
>> +    if not repo.local():
>> +        return
>I don't follow this. Can you explain why you need to bail when the
>repo isn't local?

When talking to remote repos, mercurial creates a httppeer repo as a
representation of the remote repo.  The httppeer doesn't have a .hg
directory to dump a blackbox.log in, so we don't do the blackbox setup for
those kinds of repos.  I'll add a comment explaining that.

More information about the Mercurial-devel mailing list