[PATCH] dirstate: fix generator/list error when using python 2.7

Benoit Boissinot bboissin at gmail.com
Mon Feb 11 15:25:28 CST 2013


On Mon, Feb 11, 2013 at 10:21 PM, Bryan O'Sullivan <bos at serpentine.com>wrote:

> On Sun, Feb 10, 2013 at 4:37 PM, Benoit Boissinot <bboissin at gmail.com>wrote:
>
>> If that's what you actually want to catch (like what was done
>> previously), you need to check errno for ENOENT
>>
>
> Actually, Durham's patch doesn't change the semantics of the code.
> statfiles turns all lstat results that would cause OSError to be thrown
> into None entries in the result list.
>
> It's possible that the prior patch that he's modifying was wrong, but I
> don't think so (haven't thought about it deeply).
>

At least that's the behaviour of the pure python version (in posix.py).
Might be a bug of the C code, or the python code being too defensive.


>
> Patch crewed as-is for now.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130211/93d36c7a/attachment.html>


More information about the Mercurial-devel mailing list