[PATCH 16 of 19] localrepo: use workingcontext members instead of changes array during commit

Pierre-Yves David pierre-yves.david at logilab.fr
Tue Feb 12 07:59:15 CST 2013


On Sun, Feb 10, 2013 at 03:30:06PM -0800, David Schleimer wrote:
> This changes localrepo.commit from building an array of changes, and
> constructing a new workingcontext from that array to constructiong a
> workingcotext, calling it's status method to fill in it's lists of
> changes, and hten munging those lists.  this is preperatory to moving
> the actual munging logic into workingcontext.  I also believe this
> diff is a readability improvement, since it uses named methods rather
> than integer list indeces to access the various file lists.

Yes big readability win down there.

-- 
Pierre-Yves David

http://www.logilab.fr/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130212/51eeaa58/attachment.pgp>


More information about the Mercurial-devel mailing list