[PATCH 6 of 6] blackbox: tests for the blackbox extension
durham at fb.com
Tue Feb 12 17:18:08 CST 2013
On 2/12/13 11:36 AM, "Pierre-Yves David" <pierre-yves.david at logilab.fr>
>On Mon, Feb 11, 2013 at 01:39:57PM -0800, Bryan O'Sullivan wrote:
>> On Sun, Feb 10, 2013 at 4:24 AM, Brodie Rao <brodie at sf.io> wrote:
>> > I think it's a little confusing that the date is completely globbed
>> > out here. Can you make the date stable and add it to the test?
>> The date is in the output from blackbox. It doesn't make sense to me to
>> a hack to make those dates constant for testing.
>Stable date does not make sense. Using regex instead of glob would be me
I don't think the way we test the date/user string is particularly
important. The latest patch series uses a fixed date and user so that if
the test fails it's easy to visually compare the lines without a glob or
regex uglying it up.
More information about the Mercurial-devel