[PATCH RFC] commit: add --reuse-message for keeping the old commit message during amend

Matt Mackall mpm at selenic.com
Tue Feb 12 22:56:02 CST 2013

On Tue, 2013-02-12 at 16:48 -0500, Augie Fackler wrote:
> On Feb 12, 2013, at 4:16 PM, Idan Kamara <idankk86 at gmail.com> wrote:
> > On Tue, Feb 12, 2013 at 11:08 PM, Durham Goode <durham at fb.com> wrote:
> >>> What about something generic like --no-editor? It's not as explicit
> >>> but we already have --editor which forces an editor, so this will do
> >>> the opposite.
> >>> 
> >>> It also opens up the possibility of appearing in other commands with
> >>> similar semantics but without being directly related to amend.
> >> 
> >> I think the name must imply some relationship with another commit, so it's
> >> semi intuitive that it's related to --amend. I think a user would be more
> >> likely to try --no-editor without --amend, and be confused when it failed.
> > 
> > The help text should (regardless of the name) say that this option is only
> > relevant when used with --amend.
> Strawman alternative: a --fast-amend option that doesn't pop up an
> editor, so you can pass only one flag (that is, --fast-amend would be
> like --amend --reuse-message).

I'm now inclined to think that 'hg commit --amend' will eventually be
replaced by 'hg amend', which will have a different default. Then we'll
deprecate --amend on commit.

So I think we should leave this alone. But I don't think we've got quite
enough experience here to add the new amend command yet.

Mathematics is the supreme nostalgia of our time.

More information about the Mercurial-devel mailing list