AW: [PATCH 0 of 4] detect unnecessary glob lines

Simon He. simohe at besonet.ch
Wed Feb 13 03:07:49 CST 2013


No, I still do not know how to run tests on windows. The tests have passed
on linux. (I should have written this, sorry.)
I planned to check the output on the buildbot for messages about unnecessary
glob lines.

I will try to fix the typos and hope I will find all...

Greetings,
Simon

On Wed, 13 Feb 2013 at 00:23 Benoit Boissinot <bboissin at gmail.com> wrote:
> On Wed, Feb 13, 2013 at 12:05 AM, Simon Heimberg <simohe at besonet.ch>
wrote:
> * Patch 4 checks for glob lines not containing any glob character (one of
/*?).
> * Patch 3 fixes the found lines (before they pop up in
test-check-code-hg.t
>   because of patch 4)
> * Patch 2 reports the remaining unnecessary glob lines when running the
tests
>   on windows. (This is the system with "/" matching for "\". When it
matches
>   here, the glob is unnecessary.)
> * Patch 1 is a step in the direction of the next patch.
>
> All modified and mentioned tests pass.
>
> Looks good (except for some typos) in some patch descriptions. Did you run
the tests on windows?
> 
> Cheers,
> 
> Benoit



More information about the Mercurial-devel mailing list