[PATCH 2 of 2 RFCv2] commands: introduce stash command

[Kevin Bullock]

On Feb 18, 2013, at 6:10 AM, Idan Kamara wrote:

> On Mon, Feb 18, 2013 at 2:03 AM, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
> >
> >
> > On 15 févr. 2013, at 01:15, Idan Kamara wrote:
> >
> > > # HG changeset patch
> > > # User Idan Kamara <idankk86 at gmail.com>
> > > # Date 1360886982 -7200
> > > # Node ID 06dd5eda17402c1e89a1aa212e340b146394fad8
> > > # Parent  d4c029076cf2213ad680a53dfd32b0886b2b7be0
> > > commands: introduce stash command
> >
> > I'm very happy to see this happening. Having a sane and stable solution to
> > shelve/unshelve is very important.
> >
> > I not sure that putting that as a core command is the right things to do.
> > I would expect the command to be introduced in an extension before getting
> > into core.
> 
> I guess that's fine since it relies on some fairly new features in core.
> I just hope it won't require all sorts of glue code to work properly as an
> extension.
> 
> How do others feel?

I'd rather see it as an extension first as well.

> > > Stashes are unnamed (by default) and can be listed using --list and
> > > inspected
> > > with -s/--show.
> >
> > Is there real usage for unnamed stash? don't we want to force the user to
> > provide a minimal description ?

Forcing the user to think up a name kills most of the usefulness of this feature. If I want to stash some work in progress in my working dir, it's because my mind is already onto the next thing I have to work on. I want to get the current cruft out of the way as quickly as possible.

> > > and is identified by a bookmark under a special namespace '.hg/stash/'.
> >
> > Muh? what does stash as do do with bookmark? Can't you keep the label
> > internally? (and expose them in revset if needed)
> 
> Keep it internally how? A dedicated file in .hg/? Why not use an
> existing mechanism?

I agree with Pierre-Yves, using bookmarks for this would be a little wonky. Seems motivated by the implementation details of Git's stash more than anything else.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock