[PATCH 2 of 3 STABLE] commands: make outgoing-like commands sensitive to branch in URL (issue3829)

Mads Kiilerich mads at kiilerich.com
Mon Feb 25 15:40:40 CST 2013

On 02/18/2013 07:09 AM, FUJIWARA Katsunori wrote:
> At Mon, 18 Feb 2013 00:26:36 +0900, FUJIWARA Katsunori wrote:
>> # HG changeset patch
>> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
>> # Date 1361113469 -32400
>> # Branch stable
>> # Node ID 373c150caa5f20ae975e086b8f211811afbd1687
>> # Parent  f63d2a3d62855a430b7a4323bbfaef1e696dc471
>> commands: make outgoing-like commands sensitive to branch in URL (issue3829)

You don't have to file issues for bugs you plan to fix "immediately". 
You are a developer and know how to use the mercurial-devel list, so 
there is no need to split the discussion and no need for keeping track 
of the issue over an extended period of time. [That should perhaps be 
stated clearly in the guidelines ...]

>> Before this patch, commands below are not sensitive to the branch
>> specified in the URL of the destination repository, even though "hg
>> push"/"hg outgoing" are so:
>>      - hg histedit --outgoing
>>      - hg summary --remote
>> These invoke "discovery.findcommonoutgoing()" without "onlyheads"
>> argument, so it returns revisions on branches other than the one
>> specified in the URL, too.
>> This patch specifies heads revisions, which are already detected by
>> "hg.addbranchrevs()" and "repo.lookup()", as "onlyheads" to
>> "discovery.findcommonoutgoing()" to limit calculation of outgoing
>> revisions.
>> This patch also removes "repo.changelog.nodesbetween()" invocations in
>> largefiles extension, because it is meaningless if
>> "discovery.findcommonoutgoing()" is invoked with "onlyheads".
> I folded also modifications for largefiles into this patch, because of
> similar "discovery.findcommonoutgoing()" fix.
> But this is not bug fix, but a kind of refactoring. So, I'll split
> this into bug fix for summary/histedit

That would still seem like something that really should be 2 or more 
separate changesets, each adding test cases for what they fix.


More information about the Mercurial-devel mailing list