AW: [PATCH 2 of 2] tests: remove glob lines which unnecessary match / for \ on windows
simohe at besonet.ch
Tue Feb 26 02:42:41 CST 2013
Having a check code recipe sounds good, but I have no idea how this could be done.
I do not know of any rule when an "os path" and when a "hg path" is printed. And also not when ui.slash is considered (when writing an "os path") and when it is not.
Sometimes it is unclear why some lines need no glob but similar ones do not. An example is mentioned in the introduction email.
I only see one possibility to avoid similar patches in the hg history. To run any modified test on windows before it's patch is pushed.
I fear that I am not the only developer who can not do this. So this would have to be done by a crew member (except when a developer mentions he has run the test on windows).
Some related threads:
locate command ignoring ui.slash: http://www.selenic.com/pipermail/mercurial-devel/2009-July/014187.html
mads about glob matching and ui.slash: http://www.selenic.com/pipermail/mercurial-devel/2012-October/045168.html
> -----Ursprüngliche Nachricht-----
> Von: Matt Mackall [mailto:mpm at selenic.com]
> Gesendet: Montag, 25. Februar 2013 23:19
> An: Simon Heimberg
> Cc: Mercurial-devel
> Betreff: Re: [PATCH 2 of 2] tests: remove glob lines which unnecessary match /
> for \ on windows
> On Sat, 2013-02-23 at 23:10 +0100, Simon Heimberg wrote:
> > # HG changeset patch
> > # User Simon Heimberg <simohe at besonet.ch> # Date 1361656497 -3600 #
> > Branch stable # Node ID 3312b3d481a6e61f988125d4472b53c7a0b00211
> > # Parent 3660cfb8b145e88b77228a1676d5c37113d93595
> > tests: remove glob lines which unnecessary match / for \ on windows
> > This lines were reported as unnecessary when running the tests on
> > windows because the path was already printed with a slash and not a
> I think I'm going to start insisting that such patches come with check-code
> recipes. It's the only hope we have for not hitting these issues constantly.
> Mathematics is the supreme nostalgia of our time.
More information about the Mercurial-devel